Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] TileMap Fix trying to get data for tile not existing in attached TileSet #51327

Merged

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Aug 6, 2021

Probably fixes (not sure as there's no minimal reproduction projects there): #29715, #43306.

I assume it's 3.x only because of the TileMap rework.
Cherry-pickable 3.3.

Example of fixed error:

  1. Initial setup:
    Godot_v3 4-beta2_win64_tamXhhVzG1

  2. After removing tile from TileSet:
    Godot_v3 4-beta2_win64_95UfIyusTa

  3. Painting a single cell next to a cell with tile id non-existant in attached TileSet:

  • 3.4.beta2:
    Godot_v3 4-beta2_win64_vlTXcfX8rq
  • this PR:
    O1bkjSk26K

@akien-mga akien-mga merged commit 92d5614 into godotengine:3.x Aug 7, 2021
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the tile_map-ensure-tile-is-in_tile_set branch August 7, 2021 12:08
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phantom tilemap collisions breaking game TileMap throws error when trying to draw/place a tile
3 participants